On Tue, Oct 30, 2018 at 9:25 AM Bhardwaj, Rajneesh <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote: > > + Srinivas > > > On 19-Oct-18 5:42 PM, Andy Shevchenko wrote: > > On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj > > <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote: > >> This adds support to show the Latency Tolerance Reporting for the IPs on > >> the PCH as reported by the PMC. The format shown here is raw LTR data > >> payload that can further be decoded as per the PCI specification. > >> > >> This also fixes some minor alignment issues in the header file by > >> removing spaces and converting to tabs at some places. > >> > > I have pushed slightly modified variant of this patch to my review and > > testing queue. > > Though this series needs a bit more work. > > Thanks again for your review Andy. I see that the infradead server is > down at the moment so i haven't seen your modifications yet. > http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy > says gateway timeout. Oops, yesterday it worked perfectly. > > I see inconsistency now with the output with the rest of nodes there. > > index printing is not needed for those nodes hence i never added. > > > I don't care much, though some can be addressed for no regression. > > > > For example, index printing. Please, remove it. I completely forgot > > about userspace powerful tools. At least two very old and nice can > > enumerate lines for you. > > Obviously the index printing is redundant. > > Index printing is required here (for LTR Show and LTR Ignore) because it > paves an obvious and easy way for the users of this driver to know the > IP number to be used for LTR ignore. This was specifically requested by > some customer and Srinivas asked me to implement this so adding him for > his inputs. So, why it should be in kernel? When user prints this, they usually call `cat /.../file`, right? Is it too hard to call `cat -n /.../file` instead? The benefit of such approach is that it's independent on the file we are printing. (Note, `grep -n <PATTERN> /.../file` does the same`) For more variants https://stackoverflow.com/questions/8206370/add-numbers-to-the-beginning-of-every-line-in-a-file > I am also planning to add some documentation for this driver later so > please consider this in current form. Good. -- With Best Regards, Andy Shevchenko
