On Wed, Sep 26, 2018 at 5:24 PM Bhardwaj, Rajneesh <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote: > On 26-Sep-18 7:26 PM, Andy Shevchenko wrote: > > On Mon, Sep 3, 2018 at 9:05 PM Rajneesh Bhardwaj > > <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote: > >> not be obtained and result in a invalid telemetry_plt_config. > > What is telemetry_plt_config? > > Internal data structure that holds platform config, maintained by the > telemetry platform driver. You need to spell if for the reader. > >> This is also applicable to the platforms where the BIOS supports IPC1 > >> device under debug configurations but IPC1 is disabled by user or the > >> policy. > >> > >> This change allows user to know the reason for not seeing entries under > >> /sys/kernel/debug/telemetry/* when there is no apparent failure at boot. > >> +exit: > >> + pr_debug(pr_fmt(DRIVER_NAME) " Failed\n"); > > Completely useless. > > > > Device core does it in generic way. > > If i remove this print then perhaps there is no need of this patch. Maybe. > Reason to print this is that the platform driver / core driver does not > show any error. If the code fails and returns 0 — it's a bug in error reporting inside the code. > In-fact they are even loaded in module table. OTOH, this > debugfs interface fails. This is very confusing to the users if they > check the lsmod output so i feel this print might help. Again, device core *already has* this and even more (it prints also a return code!). -- With Best Regards, Andy Shevchenko
