On Mon, Sep 3, 2018 at 9:05 PM Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote: > > On some Goldmont based systems such as ASRock J3455M the BIOS may not > enable the IPC1 device that provides access to the PMC and PUNIT. In > such scenarios, the ioss and pss resources from the platform device can IOSS PSS > not be obtained and result in a invalid telemetry_plt_config. What is telemetry_plt_config? > This is also applicable to the platforms where the BIOS supports IPC1 > device under debug configurations but IPC1 is disabled by user or the > policy. > > This change allows user to know the reason for not seeing entries under > /sys/kernel/debug/telemetry/* when there is no apparent failure at boot. > > Cc: Matt Turner <matt.turner@xxxxxxxxx> > Cc: Len Brown <len.brown@xxxxxxxxx> > Cc: Souvik Kumar Chakravarty <souvik.k.chakravarty@xxxxxxxxx> > Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxx> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198779 > There should be not a blank line. > Acked-by: Matt Turner <matt.turner@xxxxxxxxx> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> > +exit: > + pr_debug(pr_fmt(DRIVER_NAME) " Failed\n"); Completely useless. Device core does it in generic way. -- With Best Regards, Andy Shevchenko
