On Mon, 2018-06-18 at 11:00 +0300, Andy Shevchenko wrote: > On Mon, Jun 18, 2018 at 3:59 AM <Mario.Limonciello@xxxxxxxx> wrote: > > > Thanks for confirming. My personal opinion is that the kernel > > shouldn't set > > precedent to this type of blanket quirk (all BIOS version) for > > machines with > > BIOS not matching kernel behavior but are still getting updates > > that can be > > fixed. The proper thing to do is to get BIOS fixed in that > > instance. > > > > Since Dell publishes FW updates to LVFS for this platform, fwupd is > > integrated > > into most major distros and it's really easy to install the updates > > from Linux I > > have confidence that affected people will be installing this BIOS > > update to > > fix the issue. > > > > So I would say that either: > > 1) Drop this patch. > > 2) Create a new macro that can match < $VERSION and re-configure > > your patch > > to do that too. > > 3) Change your patch to detect if running on XPS 9370 and missing > > this token > > and show a warning in kernel log that there is a FW problem and you > > will want to check for a FW update to fix it. > > Thanks, Mario, for your input! > > I like options 1) or 3), though 3), if possible to reliably detect, I > prefer more. User needs to be informed that there is a BIOS fix. I think 3) is not that hard to do. I'll look into it and send a patch (but probably not until next week).
