> -----Original Message----- > From: Timur Kristóf [mailto:timur.kristof@xxxxxxxxx] > Sent: Sunday, June 17, 2018 2:51 PM > To: Limonciello, Mario; pali.rohar@xxxxxxxxx > Cc: andy.shevchenko@xxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; > venemo@xxxxxxxxxxxxxxxxx; mjg59@xxxxxxxxxxxxx; dvhart@xxxxxxxxxxxxx; > andy@xxxxxxxxxxxxx > Subject: Re: [PATCH] Fix AC keyboard backlight timeout on Dell XPS 13 9370. > > On Fri, 2018-06-15 at 15:16 +0000, Mario.Limonciello@xxxxxxxx wrote: > > > Thank you Mario! > > > > > > Sure, it makes sense to restrict the quirk to firmware which is > > > known > > > to be buggy. I will be happy to do that when the issue is fixed by > > > new > > > firmware update! > > > > > > In the meantime I've been running 4.17-rc7 with this patch added, > > > and > > > it works well for me. > > > > > > Though not sure if this could still make it into 4.17, but would be > > > nice! > > > > > > Best regards, > > > Timur > > > > Timur, > > > > I believe this behavior your encountered /may/ be resolved in FW > > 1.4.0 that was published recently. > > > > http://www.dell.com/support/home/us/en/19/Drivers/DriversDetails?driv > > erId=3N2X8 > > https://fwupd.org/lvfs/component/720/all > > > > Thanks, > > > > Hi Mario, > > Yes, it appears that the necessary token is now there as of BIOS 1.4.0 > How would you like to proceed? I would suggest to leave the patch as-is > for the sake of users who don't update their BIOS. I've looked into how > to restrict the solution for just older BIOS versions, but as far as I > could tell there is no way to express "less than 1.4.0" with DMI_MATCH. > > What do you think? > > Thanks & best regards, > Tim Timur, Thanks for confirming. My personal opinion is that the kernel shouldn't set precedent to this type of blanket quirk (all BIOS version) for machines with BIOS not matching kernel behavior but are still getting updates that can be fixed. The proper thing to do is to get BIOS fixed in that instance. Since Dell publishes FW updates to LVFS for this platform, fwupd is integrated into most major distros and it's really easy to install the updates from Linux I have confidence that affected people will be installing this BIOS update to fix the issue. So I would say that either: 1) Drop this patch. 2) Create a new macro that can match < $VERSION and re-configure your patch to do that too. 3) Change your patch to detect if running on XPS 9370 and missing this token and show a warning in kernel log that there is a FW problem and you will want to check for a FW update to fix it.
