On Tue, May 22, 2018 at 9:48 PM, Daniel Drake <drake@xxxxxxxxxxxx> wrote: > On Tue, May 22, 2018 at 4:11 AM, Chris Chiu <chiu@xxxxxxxxxxxx> wrote: >> On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >>> Btw, I mistakenly thought that patch in the queue for-next, while it's >>> not. So, I'm going to drop it now. >>> Feel free to re-submit a new (better) version. >> >> So it's better to handle NOTIFY_KBD_BRTUP, BRTDOWN, BRTTOGGLE >> (c4, c5, c7) in the driver and no need to pass it up to userspace? I'll work >> out a patch for this. > > Yes, let's explore this approach before submitting another patch to Andy. > > Thanks > Daniel Hi Andy, I've made my change to set the brightness level directly in the driver, but the OSD doesn't show correctly correspond to the level value. The brightness shows OK in /sys/class/led/xxxx/brighness but the OSD always shows level 0. I thought GNOME should read the brightness from /sys before showing OSD? Chris