On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg <bberg@xxxxxxxxxx> wrote: > >> I had a quick chat with Bastien about this. The conclusion was that >> reusing the TOGGLE key may be problematic for gnome-settings-daemon. >> And the alternative of a new CYCLE key also has some caveats. >> >> The most straight forward solution is likely to simply handle the >> brightness change in the kernel and not report the key to userspace at >> all. This should work just fine and at least GNOME will show an on >> screen display in response to the brightness change. >> >> Do you think that approach would work well? > > Am I right we are waiting for Daniel's answer? > > Btw, I mistakenly thought that patch in the queue for-next, while it's > not. So, I'm going to drop it now. > Feel free to re-submit a new (better) version. > > -- > With Best Regards, > Andy Shevchenko So it's better to handle NOTIFY_KBD_BRTUP, BRTDOWN, BRTTOGGLE (c4, c5, c7) in the driver and no need to pass it up to userspace? I'll work out a patch for this. Chris
