Re: [PATCH] platform/x86: intel-vbtn: Reset wakeup capable flag on removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 16, 2018 at 12:18 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Wed, Feb 28, 2018 at 3:09 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>>
>> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>
>> The intel-vbtn device will not be able to wake up the system any more
>> after removing the notify handler provided by its driver, so make
>> its sysfs attributes reflect that.
>
> Are there devices that can and should wake up system even after driver
> is unbound from device?

Maybe, but then something needs to configure them for wakeup on suspend, right?

> Should we move resetting wakeup flag into the
> driver core so we do not have to do it in each individual driver?

It could be done in the driver core or bus type.  The bus type level
is a better place probably, because of PCI.

Anyway, the idea of this patch was to clear the bit in the same entity
that set it. :-)



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux