Re: [PATCH] platform/x86: intel-vbtn: Reset wakeup capable flag on removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 28, 2018 at 3:09 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The intel-vbtn device will not be able to wake up the system any more
> after removing the notify handler provided by its driver, so make
> its sysfs attributes reflect that.

Are there devices that can and should wake up system even after driver
is unbound from device? Should we move resetting wakeup flag into the
driver core so we do not have to do it in each individual driver?

>
> Fixes: 91f9e850d465 (platform: x86: intel-vbtn: Wake up the system from suspend-to-idle)
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>
> Resend with the correct platform-driver-x86 list address.
>
> ---
>  drivers/platform/x86/intel-vbtn.c |    1 +
>  1 file changed, 1 insertion(+)
>
> Index: linux-pm/drivers/platform/x86/intel-vbtn.c
> ===================================================================
> --- linux-pm.orig/drivers/platform/x86/intel-vbtn.c
> +++ linux-pm/drivers/platform/x86/intel-vbtn.c
> @@ -154,6 +154,7 @@ static int intel_vbtn_remove(struct plat
>  {
>         acpi_handle handle = ACPI_HANDLE(&device->dev);
>
> +       device_init_wakeup(&device->dev, false);
>         acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, notify_handler);
>
>         /*
>
>

Thanks.

-- 
Dmitry



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux