Re: [platform-drivers-x86:testing 6/6] drivers/platform/x86/Kconfig:128:error: recursive dependency detected!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-03-08 at 13:50 -0800, Darren Hart wrote:
> On Thu, Mar 08, 2018 at 12:03:11PM -0800, Darren Hart wrote:
> > On Fri, Mar 09, 2018 at 02:45:05AM +0800, kbuild test robot wrote:


> > Well, apparently this needs more work. I don't know why I didn't see
> > this
> > recursive error with this version of my patch. I'll see if there is
> > anything I
> > can do...
> > 
> > Andy, this means we'll probably have to break testing and roll this
> > back.

Fine, sometimes crap happens.

> OK, I spent some time mapping this out and... oi, what a mess. Greg KH
> is here
> at OSLS and I worked through this with him - he suggested just
> simplifying this
> by forcing DELL_SMBIOS to be <= DCDBAS if DCDBAS is enabled. I've
> updated my
> patch in testing to reflect this, and force pushed. Hopefully nobody
> but 0-day
> is impacted. This is bad form, but sending something to Linus with
> Kconfig
> errors would be worse.

Agree.

> Avoid the errors by simplifying the dependency and forcing DELL_SMBIOS
> to be <= DCDBAS if DCDBAS is enabled (thanks to Greg KH for the
> suggestion).
> 
> Cc: Mario.Limonciello@xxxxxxxx
> Signed-off-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx>

Suggested-by: Greg KH?


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux