Re: [platform-drivers-x86:testing 4/5] drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-03-07 at 09:50 -0800, Darren Hart wrote:
> On Wed, Mar 07, 2018 at 02:18:25PM +0200, Andy Shevchenko wrote:
> > On Tue, 2018-03-06 at 18:16 -0800, Darren Hart wrote:
> > > On Tue, Mar 06, 2018 at 05:52:57PM -0800, Darren Hart wrote:
> > > > On Tue, Mar 06, 2018 at 05:53:16AM +0000, Mario.Limonciello@dell
> > > > .com
> > > >  wrote:
> > > > > 
> > 

> > One question, can't we put select to different place and option with
> > some other name to avoid ! in above conditional?
> 
> Hi Andy,
> 
> DELL_SMBIOS_SMM is the right place to set the flag for a dependency on
> DCDBAS.
> It *works* to change the above to:
> 
> depends on !DELL_SMBIOS_SMM || (DCDBAS || DCDBAS=n)
> 
> But the Kconfig tooling complains about a circular dependency (even
> thought it
> isn't really). The intermediate DELL_SMBIOS_USING_DCDBAS just works
> around that.
> 
> Your asking if we can do something to avoid the "!". Why should we try
> to do
> that? What's the problem with the "!"?

No problem.

>  (Noting that yes, this is ugly, but it's
> a minimal change that is functional within the context of rather messy
> design
> and interdependencies that we have to work with between these
> modules).

I'm fine with it, I was rather wondering. 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux