On Wed, Mar 07, 2018 at 02:18:25PM +0200, Andy Shevchenko wrote: > On Tue, 2018-03-06 at 18:16 -0800, Darren Hart wrote: > > On Tue, Mar 06, 2018 at 05:52:57PM -0800, Darren Hart wrote: > > > On Tue, Mar 06, 2018 at 05:53:16AM +0000, Mario.Limonciello@xxxxxxxx > > > wrote: > > > > > > > > config DELL_SMBIOS > > tristate "Dell SMBIOS driver" > > + depends on !DELL_SMBIOS_USING_DCDBAS || (DCDBAS || DCDBAS=n) > > > > One question, can't we put select to different place and option with > some other name to avoid ! in above conditional? Hi Andy, DELL_SMBIOS_SMM is the right place to set the flag for a dependency on DCDBAS. It *works* to change the above to: depends on !DELL_SMBIOS_SMM || (DCDBAS || DCDBAS=n) But the Kconfig tooling complains about a circular dependency (even thought it isn't really). The intermediate DELL_SMBIOS_USING_DCDBAS just works around that. Your asking if we can do something to avoid the "!". Why should we try to do that? What's the problem with the "!"? (Noting that yes, this is ugly, but it's a minimal change that is functional within the context of rather messy design and interdependencies that we have to work with between these modules). Thanks, -- Darren Hart VMware Open Source Technology Center
