Re: [PATCH v5 01/12] drivers: base: Unified device connection lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01-03-18 10:32, Andy Shevchenko wrote:
On Thu, Mar 1, 2018 at 9:28 AM, Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
Hi,

On Thu, Mar 01, 2018 at 12:56:57AM +0000, Jun Li wrote:
+struct device *device_find_connection(struct device *dev, const char
+*con_id) {
+   return __device_find_connection(dev, con_id, generic_match, NULL); }

-       return __device_find_connection(dev, con_id, generic_match, NULL);
+       return __device_find_connection(dev, con_id, NULL, generic_match);

Good catch!

It seems I proposed to put function first parameter followed by opaque
data pointer for it.
In that case it would be exactly like now.

Yes, but as mentioned I decided to keep it as is, so this is really a bug,
will fix for v6.

Regards,

Hans



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux