On Friday 23 February 2018 22:14:17 Andy Shevchenko wrote: > On Fri, 2018-02-23 at 21:09 +0100, Pali Rohár wrote: > > On Friday 23 February 2018 21:40:56 Andy Shevchenko wrote: > > > On Fri, 2018-02-23 at 19:19 +0000, Mario.Limonciello@xxxxxxxx wrote: > > > > > -----Original Message----- > > > > > From: Marco d'Itri [mailto:md@xxxxxxxx] > > > > > Sent: Friday, February 23, 2018 1:06 PM > > > > > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > > > > > Cc: pali.rohar@xxxxxxxxx > > > > > Subject: Re: dell_smbios in 4.15 and keyboard backlight > > > > > > > > > > On Feb 23, Mario Limonciello <superm1@xxxxxxxxx> wrote: > > > > > > > > > > > Can you please email me on mario.limonciello@xxxxxxxx for this > > > > > > topic? > > > > > > > > > > > > I would be interested to know do you have dell-smbios-smm or > > > > > > dell-smbios-wmi not loading or compiling? > > > > > > > > > > Oops... The new modules have not been enabled yet by the Debian > > > > > kernel > > > > > team, so this explains why I could not find them. > > > > > Thank you for your help, I will get back to you if I will still > > > > > have > > > > > troubles with the new kernel. > > > > > > > > > > > > > If you don't mind I'm going to CC this to the mailing list for > > > > discussion. I think > > > > you identified a valid config problem. > > > > > > > > Andy, Darren, > > > > > > > > Marco (CC'ed) privately emailed Pali and I to discuss an issue > > > > that > > > > dell-laptop > > > > wasn't working properly for him and dell-smbios couldn't find a > > > > backend. > > > > > > > > I thought at first it was an issue of the race condition recently > > > > discussed but > > > > it's actually a case that the distro kernel he's using compiled: > > > > > > > > DELL_SMBIOS > > > > DELL_LAPTOP > > > > > > > > But didn't select DELL_SMBIOS_WMI or DELL_SMBIOS_SMM. > > > > > > Distros have to enable whatever they want to. > > > > But this combination of options is invalid and does not make sense. > > > > Perhaps, you can explain this to Torvalds then? > > https://lkml.org/lkml/2017/11/18/257 That is something different. Linus wrote: You add new drivers and then default them to "on". But here we have a driver dell-laptop.ko which needs for proper work driver dell-smbios.ko. And dell-smbios.ko needs for proper work dell-smbios-smm.ko or dell-smbios-wmi.ko (one is enough). But if you do not enable (or need) dell-laptop.ko then you do not need all others. (There are also other drivers which needs dell-smbios.ko). So I agree with Linus, CONFIG_DELL_SMBIOS does not have to be on by default. But it should be automatically enabled when CONFIG_DELL_LAPTOP is set. We have just a complicated dependency graph and I'm not sure if we can describe it for Kconfig definitions... And if Kconfig does not support it I would suggest to add #ifdef/#error checks into driver code to prevent compilation of non sense combinations. I think it is better to throw compile error as trying to compile kernel with non sense options which would lead to problem like we got reported. -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: PGP signature
