On Fri, 2018-02-23 at 19:19 +0000, Mario.Limonciello@xxxxxxxx wrote: > > -----Original Message----- > > From: Marco d'Itri [mailto:md@xxxxxxxx] > > Sent: Friday, February 23, 2018 1:06 PM > > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > > Cc: pali.rohar@xxxxxxxxx > > Subject: Re: dell_smbios in 4.15 and keyboard backlight > > > > On Feb 23, Mario Limonciello <superm1@xxxxxxxxx> wrote: > > > > > Can you please email me on mario.limonciello@xxxxxxxx for this > > > topic? > > > > > > I would be interested to know do you have dell-smbios-smm or > > > dell-smbios-wmi not loading or compiling? > > > > Oops... The new modules have not been enabled yet by the Debian > > kernel > > team, so this explains why I could not find them. > > Thank you for your help, I will get back to you if I will still have > > troubles with the new kernel. > > > > If you don't mind I'm going to CC this to the mailing list for > discussion. I think > you identified a valid config problem. > > Andy, Darren, > > Marco (CC'ed) privately emailed Pali and I to discuss an issue that > dell-laptop > wasn't working properly for him and dell-smbios couldn't find a > backend. > > I thought at first it was an issue of the race condition recently > discussed but > it's actually a case that the distro kernel he's using compiled: > > DELL_SMBIOS > DELL_LAPTOP > > But didn't select DELL_SMBIOS_WMI or DELL_SMBIOS_SMM. Distros have to enable whatever they want to. Can it be the Dell model, that survives w/o one of above or even both? > I remember hypothesizing about this with one of the earlier versions > of the > patch series but the decision was to just hide config DELL_SMBIOS as > an invisible > tristate. > Because this is a real problem happening I think we need something > like this: > > diff --git a/drivers/platform/x86/Kconfig > b/drivers/platform/x86/Kconfig > index 9a8f964..f2f548b 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -107,6 +107,7 @@ config ASUS_LAPTOP > > config DELL_SMBIOS > tristate > + depends on DELL_SMBIOS_WMI || DELL_SMBIOS_SMM This will simple not work. > > config DELL_SMBIOS_WMI > tristate "Dell SMBIOS calling interface (WMI implementation)" > > Thoughts? -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy
