> -----Original Message----- > From: platform-driver-x86-owner@xxxxxxxxxxxxxxx [mailto:platform-driver-x86- > owner@xxxxxxxxxxxxxxx] On Behalf Of Andy Shevchenko > Sent: Monday, February 5, 2018 10:18 AM > To: Darren Hart <dvhart@xxxxxxxxxxxxx> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx; AceLan Kao > <acelan.kao@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > pali.rohar@xxxxxxxxx; Limonciello, Mario <Mario_Limonciello@xxxxxxxx>; Rafael > Wysocki <rjw@xxxxxxxxxxxxx> > Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver > > On Wed, 2018-01-31 at 13:37 -0800, Darren Hart wrote: > > On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote: > > > Remove code duplication by converting driver to pure ACPI one. > > > > I have fixed couple issues, but... > > > +Rafael > > > > I don't see any reason *not* to do this, it seems the acpi driver > > model provides > > some of the boilerplate stuff we were doing manually before as a > > platform > > device. I'm scratching my head wondering why we did this as a > > platform-driver in > > the first place now... > > ...I still keep in my review queue in a hope that someone can actually > test this on real hardware. > > -- > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Intel Finland Oy Andy, I'm pretty sure XPS 9365 can test this. I was going to try but https://patchwork.kernel.org/patch/10194503/ was not able to compile on top of platform-x86/for-next. That was the only one I saw at patchwork. drivers/platform/x86/intel-vbtn.c:172:11: error: ‘ACPI_BUTTON_CLASS’ undeclared here (not in a function) .class = ACPI_BUTTON_CLASS, ^ drivers/platform/x86/intel-vbtn.c:178:2: error: unknown field ‘driver’ specified in initializer .driver = { ^ scripts/Makefile.build:316: recipe for target 'drivers/platform/x86/intel-vbtn.o' failed make[5]: *** [drivers/platform/x86/intel-vbtn.o] Error 1 is that different than the one in your review queue? Thanks,
