On Wed, 2018-01-31 at 13:37 -0800, Darren Hart wrote: > On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote: > > Remove code duplication by converting driver to pure ACPI one. > I have fixed couple issues, but... > +Rafael > > I don't see any reason *not* to do this, it seems the acpi driver > model provides > some of the boilerplate stuff we were doing manually before as a > platform > device. I'm scratching my head wondering why we did this as a > platform-driver in > the first place now... ...I still keep in my review queue in a hope that someone can actually test this on real hardware. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy