On 18-01-13 00:33:09, Matthew Thode wrote: > On 18-01-12 15:07:12, David Herrmann wrote: > > Hi Andy > > > > On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > > >> Cc: Matthew Thode <mthode@xxxxxxxxxx> > > > > > > Shouldn't be Suggested-by or even Signed-off-by? > > > > The patch is different (Matthew originally suppressed the ACPI event), > > so I did not copy the sign-off. Please add Suggested-by, if that is an > > acceptable tag. > > > > >> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx> > > > > > > > > >> + case TP_HKEY_EV_PALM_DETECTED: > > >> + case TP_HKEY_EV_PALM_UNDETECTED: > > > > > >> + /* palm detected hovering the keyboard, forward to user-space > > >> + * via netlink for consumption */ > > > > > > Comment style is > > > /* > > > * Multi line comment. > > > * This is an example. > > > */ > > > > All other 6 comments in this function follow the style I used here, so > > I tried to be consistent. But feel free to amend this change. > > > > I'm fine with a signed-off-by or tested-by or suggested-by. There is a > spelling mistake though, 'hoveres' should be hovers. > Is there anything else I can do here? I'm not sure any of us have the ability to find out what lenovo actualy wants this for. Sorry for the double reply, dmarc can be hell. -- Matthew Thode
Attachment:
signature.asc
Description: PGP signature
