On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > This patch prevents the thinkpad_acpi driver from warning about 2 event > codes returned for keyboard palm-detection. No behavioral changes, > other than suppressing the warning in the kernel log. The events are > still forwarded via acpi-netlink channels. > > We could, optionally, decide to forward the event through a > input-switch on the tpacpi input device. However, so far no suitable > input-code exists, and no similar drivers report such events. Hence, > leave it an acpi event for now. > > Note that the event-codes are named based on empirical studies. On the > ThinkPad X1 5th Gen the sensor can be found underneath the arrow key. > > Cc: Matthew Thode <mthode@xxxxxxxxxx> Shouldn't be Suggested-by or even Signed-off-by? > Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx> > + case TP_HKEY_EV_PALM_DETECTED: > + case TP_HKEY_EV_PALM_UNDETECTED: > + /* palm detected hovering the keyboard, forward to user-space > + * via netlink for consumption */ Comment style is /* * Multi line comment. * This is an example. */ > + return true; I can fix the latter, but I have to be sure all credits are given properly. -- With Best Regards, Andy Shevchenko
