On Mon, Jan 22, 2018 at 12:23 PM, Vadim Pasternak <vadimp@xxxxxxxxxxxx> wrote: >> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table); > > I am not sure about the location of MODULE_DEVICE_TABLE record. > Should it be placed at the end of the module or after mlxplat_dmi_table > declaration? Yeah, it would be better. I dunno if Darren is going to ask for another version or fix this manually when apply. To be on the safer side, send a v3 with properly attached line as Vadim suggested. -- With Best Regards, Andy Shevchenko