> -----Original Message----- > From: Ivan Vecera [mailto:ivecera@xxxxxxxxxx] > Sent: Monday, January 22, 2018 12:12 PM > To: platform-driver-x86@xxxxxxxxxxxxxxx > Cc: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; Bjørn Mork <bjorn@xxxxxxx> > Subject: [PATCH v2] platform/x86: mlx-platform: fix module aliases > > Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is not loaded > automatically. The driver should use MODULE_DEVICE_TABLE together with > existing mlxplat_dmi_table instead. > > Changes: > v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn) > > Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from > arch/x86") > Cc: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: Bjørn Mork <bjorn@xxxxxxx> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx> > --- > drivers/platform/x86/mlx-platform.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx- > platform.c > index 504256c3660d..5a8b475668fb 100644 > --- a/drivers/platform/x86/mlx-platform.c > +++ b/drivers/platform/x86/mlx-platform.c > @@ -370,8 +370,4 @@ module_exit(mlxplat_exit); MODULE_AUTHOR("Vadim > Pasternak (vadimp@xxxxxxxxxxxx)"); MODULE_DESCRIPTION("Mellanox > platform driver"); MODULE_LICENSE("Dual BSD/GPL"); - > MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:"); > +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table); I am not sure about the location of MODULE_DEVICE_TABLE record. Should it be placed at the end of the module or after mlxplat_dmi_table declaration? > -- > 2.13.6
