Re: [PATCH 1/3 v6] battery: Add the battery hooking API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 20, 2017 at 10:23:30PM +0100, Ognjen Galić wrote:
> On 20/12/2017, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > On Wed, Dec 20, 2017 at 03:30:18PM +0100, Ognjen Galić wrote:
> >> On 18/12/2017, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> >> > Also, what if someone attempts to add a hook when the ACPI battery
> >
> >> > module is not loaded?  Will that still work?
> >>
> >> The module that requests the hooks will fail to load with the following
> >>
> >> > [  149.259127] thinkpad_acpi: Unknown symbol battery_hook_register (err
> >> > 0)
> >> > [  149.259158] thinkpad_acpi: Unknown symbol battery_hook_unregister
> >> > (err 0)
> >
> > Will a synchronous request_module() address this concern?
> >
> 
> I don't know, that check seems like a pre-load check. Like metadata
> checking about
> the module. modprobe handles the module loading just fine.

Read to quick trying to catch up and misunderstood the problem. Please
disregard.

-- 
Darren Hart
VMware Open Source Technology Center



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux