On 20/12/2017, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > On Wed, Dec 20, 2017 at 03:30:18PM +0100, Ognjen Galić wrote: >> On 18/12/2017, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: >> > Also, what if someone attempts to add a hook when the ACPI battery > >> > module is not loaded? Will that still work? >> >> The module that requests the hooks will fail to load with the following >> >> > [ 149.259127] thinkpad_acpi: Unknown symbol battery_hook_register (err >> > 0) >> > [ 149.259158] thinkpad_acpi: Unknown symbol battery_hook_unregister >> > (err 0) > > Will a synchronous request_module() address this concern? > I don't know, that check seems like a pre-load check. Like metadata checking about the module. modprobe handles the module loading just fine. > -- > Darren Hart > VMware Open Source Technology Center >
