On Wed, Dec 13, 2017 at 12:13 AM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, Dec 12, 2017 at 6:00 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: >> On Tue, Dec 12, 2017 at 10:02:36AM +0200, Andy Shevchenko wrote: > >>> Just in case you didn't promote it yet, could you move inclusion to be >>> more ordered alphabetically? (After linux/acpi.h I suppose) >> >> I had done that initially, but realized the entire list is in no apparent order >> and it wasn't just moving the one line he added. So it'll need to be a cleanup >> patch since all the test builds have run already. > > Ah, fair enough. Do you mean the includes listed alphabetically such as below? I can send a patch to clean it up. #include <linux/acpi.h> #include <acpi/acpi_bus.h> #include <linux/dmi.h> #include <linux/init.h> #include <linux/input.h> #include <linux/input/sparse-keymap.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/suspend.h> > > -- > With Best Regards, > Andy Shevchenko -- Cheers, Alex Hung
