Re: [PATCH][V2] intel-hid: add a DMI quirk to support Wacom MobileStudio Pro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 12, 2017 at 10:02:36AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 12, 2017 at 2:51 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > On Mon, Dec 11, 2017 at 02:13:40PM -0800, Jason Gerecke wrote:
> >> On Fri, Dec 8, 2017 at 4:04 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> >> > On Thu, Dec 07, 2017 at 11:40:23AM +0800, Alex Hung wrote:
> >> >> HEBC method reports capabilities of 5 button array but Wacom
> >> >> MobileStudio Pro does not have this control method. A DMI quirk
> >> >> was created to enable 5 button array for this system.
> >> >
> >> > Jason, have you been able to verify this patch with testing?
> >> >
> >>
> >> I tested the attachment at [1], which produces an identical copy of
> >> intel-hid.c as applying this patch to the
> >> platform-drivers-x86/review-dvhart branch of
> >> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git.
> >>
> >> Assuming that's the correct code, feel free to attach the following:
> >> Tested-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> >
> > Great, thanks. Queued up for testing.
> 
> Just in case you didn't promote it yet, could you move inclusion to be
> more ordered alphabetically? (After linux/acpi.h I suppose)

I had done that initially, but realized the entire list is in no apparent order
and it wasn't just moving the one line he added. So it'll need to be a cleanup
patch since all the test builds have run already.

-- 
Darren Hart
VMware Open Source Technology Center



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux