On Thursday 19 October 2017 12:50:07 Mario Limonciello wrote:
> This is intended to be variable and provided by the platform.
> Some platforms this year will be adopting a 32k WMI buffer, so don't
> complain when encountering those platforms or any other future changes.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> Reviewed-by: Edward O'Callaghan <quasisec@xxxxxxxxxx>
Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> ---
> drivers/platform/x86/dell-wmi.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index b2bd396acac5..da4f629d0831 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -624,7 +624,7 @@ static void dell_wmi_input_destroy(struct wmi_device *wdev)
> * Vendor Signature 0 4 "DELL"
> * Object Signature 4 4 " WMI"
> * WMI Interface Version 8 4 <version>
> - * WMI buffer length 12 4 4096
> + * WMI buffer length 12 4 <length>
> */
> static int dell_wmi_check_descriptor_buffer(struct wmi_device *wdev)
> {
> @@ -674,10 +674,6 @@ static int dell_wmi_check_descriptor_buffer(struct wmi_device *wdev)
> dev_warn(&wdev->dev, "Dell descriptor buffer has unknown version (%lu)\n",
> (unsigned long) buffer[2]);
>
> - if (buffer[3] != 4096)
> - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid buffer length (%d)\n",
> - buffer[3]);
> -
> priv->interface_version = buffer[2];
> ret = 0;
>
--
Pali Rohár
pali.rohar@xxxxxxxxx
