On Thu, Oct 5, 2017 at 6:02 PM, <Mario.Limonciello@xxxxxxxx> wrote:
>> > - if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
>> > - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature
>> (%8ph)\n",
>> > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) {
>> > + dev_err(&wdev->dev, "Dell descriptor buffer has invalid signature
>> (%8ph)\n",
>>
>> A nit: ping-pong programming detected.
>> Looks like current patch 2 should go at least after this one.
> I'll re-order them, but either way both patches are touching these lines in some
> way.
Yeah, I noticed as well.
The rule of thumb is to arrange such small and non-so-important clean
ups at the tail of the series (as possible).
--
With Best Regards,
Andy Shevchenko
