> -----Original Message----- > From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] > Sent: Thursday, October 5, 2017 12:21 AM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: dvhart@xxxxxxxxxxxxx; LKML <linux-kernel@xxxxxxxxxxxxxxx>; Platform Driver > <platform-driver-x86@xxxxxxxxxxxxxxx>; Andy Lutomirski <luto@xxxxxxxxxx>; > quasisec@xxxxxxxxxx; Pali Rohár <pali.rohar@xxxxxxxxx>; Rafael J. Wysocki > <rjw@xxxxxxxxxxxxx>; mjg59@xxxxxxxxxx; Christoph Hellwig <hch@xxxxxx>; > Greg KH <greg@xxxxxxxxx> > Subject: Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some > failures > > On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello > <mario.limonciello@xxxxxxxx> wrote: > > There is a lot of error checking in place for the format of the WMI > > descriptor buffer, but some of the potentially raised issues should > > be considered critical failures. > > > > If the buffer size or header don't match, this is a good indication > > that the buffer format changed in a way that the rest of the data > > should not be relied upon. > > > > For the remaining data set vectors, continue to notate a warning > > in undefined results, but as those are fields that the descriptor > > intended to refer to other applications, don't fail if they're new > > values. > > > - if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) > > - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature > (%8ph)\n", > > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) { > > + dev_err(&wdev->dev, "Dell descriptor buffer has invalid signature > (%8ph)\n", > > A nit: ping-pong programming detected. > Looks like current patch 2 should go at least after this one. > > > -- I'll re-order them, but either way both patches are touching these lines in some way.
