On Mon, Sep 18, 2017 at 11:00:59PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > My Fujitsu-Siemens Lifebook S6120 doesn't have the FUJ02E3 device, > but it does have FUJ02B1. That means we do register the backlight > device (and it even seems to work), but the code will oops as soon > as we try to set the backlight brightness because it's trying to > call call_fext_func() with a NULL device. Let's just skip those > function calls when the FUJ02E3 device is not present. > > Cc: Jonathan Woithe <jwoithe@xxxxxxxxxx> > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx> > Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Thanks for all the discussion on this patch. While there are a couple approaches we can take, it is clear further clean up and refactoring is in order. To fix the Ooops now, I will apply this patch to fixes and Cc Stable. Thanks, -- Darren Hart VMware Open Source Technology Center