> -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@xxxxxxxxx] > Sent: Tuesday, September 26, 2017 4:12 PM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: dvhart@xxxxxxxxxxxxx; Andy Shevchenko <andy.shevchenko@xxxxxxxxx>; > LKML <linux-kernel@xxxxxxxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx; > quasisec@xxxxxxxxxx > Subject: Re: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi > descriptor check > > On Tuesday 26 September 2017 20:50:12 Mario Limonciello wrote: > > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) > > Should not be this memcmp? IIRC we want to compare that buffer is equal > to some bytes, right? > It used to be comparing the bytes, but Andy S. thought this wasn't very clear. That's why I adjusted it to compare to the strings that the bytes used instead.
