On Sat, Sep 23, 2017 at 06:38:40PM +0930, Jonathan Woithe wrote: > Hi Darren > > The more detailed follow-up, as promised. :-) Sorry for the delay. > > On Fri, Sep 22, 2017 at 05:00:48PM -0700, Darren Hart wrote: > > On Mon, Sep 18, 2017 at 11:00:59PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > My Fujitsu-Siemens Lifebook S6120 doesn't have the FUJ02E3 device, > > > but it does have FUJ02B1. That means we do register the backlight > > > device (and it even seems to work), but the code will oops as soon > > > as we try to set the backlight brightness because it's trying to > > > > I'm curious by what you mean with "it even seems to work". Since it > > crashes when adjusting, what does it do that "works" ? > > As mentioned earlier, I have assumed that this means the backlight > adjustment works correctly if the suggested patch has been applied. Yes. > Having > thought about this some more I am unconvinced: if fext is NULL then > call_fext_func() (with the check added) can't have any effect. The > backlight adjustment might still work, but it's not due to this code path. It still calls set_lcd_level() which I assume is the thing that makes it work. -- Ville Syrjälä Intel OTC
