> -----Original Message----- > From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] > Sent: Tuesday, August 1, 2017 7:37 AM > To: Rafael J. Wysocki <rafael@xxxxxxxxxx> > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>; Platform Driver <platform-driver- > x86@xxxxxxxxxxxxxxx>; Darren Hart <dvhart@xxxxxxxxxxxxx>; LKML <linux- > kernel@xxxxxxxxxxxxxxx>; Linux ACPI <linux-acpi@xxxxxxxxxxxxxxx>; Andy > Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; Jérôme de Bretagne > <jerome.debretagne@xxxxxxxxx>; Limonciello, Mario > <Mario_Limonciello@xxxxxxxx>; Alex Hung <alex.hung@xxxxxxxxxxxxx> > Subject: Re: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from > suspend-to-idle > > On Tue, Aug 1, 2017 at 2:56 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > On Tue, Aug 1, 2017 at 1:21 AM, Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > >> On Tue, Aug 1, 2017 at 12:46 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: > >>> On Friday, July 28, 2017 02:06:36 AM Rafael J. Wysocki wrote: > > >>> Please note that this change is requisite for > >>> > >>> https://patchwork.kernel.org/patch/9873159/ > >>> > >>> so are there any objections or concerns? > >> > >> Not from my side, > >> > >> Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > > OK, thanks! > > > > I'm going to route it through the PM tree then if that's not a problem. > > Mario, are you okay with this change? > Thanks for checking. I spent a little time this morning trying to walk through the ASL as attached to the Bugzilla entry and I think this is the correct approach. Acked-By: Mario Limonciello <mario.limonciello@xxxxxxxx> Jérôme, I have one question though. These events should be happening as a pair. Press: 0xCE, Release: 0xCF. What happens with the event on power button release? Is that showing a message in the log during wakeup from S2I? Something like "unknown event 0xCF"? If so, it would be good to also catch and ignore that too. Thanks,