On Tue, Aug 1, 2017 at 1:21 AM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, Aug 1, 2017 at 12:46 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: >> On Friday, July 28, 2017 02:06:36 AM Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> >>> >>> On Dell Latitude 7275 the 5-button array is not exposed in the >>> ACPI tables, but still notifies are sent to the Intel HID device >>> object (device ID INT33D5) in response to power button actions while >>> suspended to idle. However, they are currently ignored as the >>> intel-hid driver is not prepared to take care of them. >>> >>> As a result, power button wakeup from suspend-to-idle doesn't work >>> on this platform, but suspend-to-idle is the only reliable suspend >>> variant on it (the S3 implementation in the platform firmware turns >>> out to be broken), so it would be good to handle it properly. >>> >>> For this reason, add an upfront check against the power button press >>> event (0xCE) to notify_handler() in the wakeup mode which allows it >>> to catch the power button wakeup notification on the affected >>> platform (even though priv->array is NULL on it) and should not >>> change the behavior on platforms with priv->array present (because >>> priv->array contains the event in question in those cases). >>> >>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=196115 >>> Tested-by: Jérôme de Bretagne <jerome.debretagne@xxxxxxxxx> >>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> >> >> Please note that this change is requisite for >> >> https://patchwork.kernel.org/patch/9873159/ >> >> so are there any objections or concerns? > > Not from my side, > > Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> OK, thanks! I'm going to route it through the PM tree then if that's not a problem. Thanks, Rafael
