> On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? <kernel@xxxxxxxxxx> wrote: > > > > > > > > > Darren, Andy, in light of the above I will be awaiting your review of > > > > > this series. I will submit v2 afterwards, with all remarks from both > > > > > you and Jonathan taken into account. > > > > > > > > Darren marked this series under his name to review, so, I let him to > > > > speak for us. > > > > > > The series looks good to me. Nice work Micha??. They are logically divided and > > > address issues in a procedural way (so I stopped commenting until I read the > > > full series through as a couple of times you addressed a concern from a move in > > > a cleanup to follow). > > > > > > I've applied the noted change to 7/8 and will run this through my tests, but > > > don't anticipate any problems. Jonathan, if you don't have any additional > > > concerns, let me know if I can add your Reviewed-by. > > > > With the noted change to 7/8 applied I'm happy with the resulting series. > > As you noted, there is still some scope for making things more consistent, > > especially with regard to error handling. However, that is really a > > separate task which can be addressed in a later series. This present series > > doesn't impact on this issue in any significant way so it makes sense that > > be applied. > > > > Reviewed-by: Jonathan Woithe <jwoithe@xxxxxxxxxx> > > Merged, thanks! Thanks to everyone involved. I noted your concerns about error handling in the driver, rest assured that I share them. I have a local git branch with miscellaneous fixes that I plan to submit (as one or more series) in the future. I think error handling improvements fall right into that "miscellaneous" category of fixes. For the time being I would rather concentrate on the issues I personally consider more pressing as I will most likely lose access to modern Fujitsu hardware in about six weeks and I would really like to be able to test my patches on hardware on which the code touched by these patches actually runs (LEDs come to mind, specifically). -- Best regards, Michał Kępień
