On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > This series simplifies handling of both brightness key and hotkey input > > events on Fujitsu laptops by making use of sparse keymaps. This not > > only makes the driver shorter and, hopefully, cleaner, but also enables > > us to get rid of the keycodeX fields inside struct fujitsu_bl, which > > facilitates further cleanups. Also, to simplify error handling, input > > devices registered by fujitsu-laptop are migrated to the devres API > > along the way. > > > > This series was tested on a Lifebook S7020 and a Lifebook E744. > > > > This series depends on the platform cleanup series I posted last week. > > While that series has not yet been merged into testing, Jonathan has > > reviewed it and Darren also seemed to be okay with it, so I just assumed > > it will get merged soon. I wanted to post this one as soon as possible > > as it requires a bit more thorough review and testing compared to the > > previous series I posted for fujitsu-laptop. > > Thanks for posting this. I have started going through this and hope to > complete my review by the end of this weekend. I have completed my initial review of this patch series. Aside from the single recommendation about patch 7/8 (posted separately) it looks good. I await your thoughts regarding patch 7/8 so we can finalise and sign off on this series. Regards jonathan
