On Sun, Mar 19, 2017 at 07:11:43PM +0100, Pali Rohár wrote: > On Sunday 19 March 2017 19:06:19 Hans de Goede wrote: > > Hi, > > > > On 19-03-17 16:10, Pali Rohár wrote: > > > On Thursday 16 March 2017 11:55:35 Hans de Goede wrote: > > >> Changes in v9: > > >> -Only listen to type 0x0010 kbd-led events in dell-wmi.c, these > > >> only trigger on hotkey presses > > >> -Drop the new / previous brightness comparison from dell-laptop.c > > >> now that we only get events on hotkey presses it is no longer > > >> necessary --- > > > > > > Hi! I'm really not sure if this change is correct there. > > > > > > Now you are only listening for keypress "change kbd backlight", but > > > some dell machines could change keyboard backlight also in other > > > different situations, like attaching AC adapter. I guess (but I'm > > > not sure) this probably does not send keypress event. > > > > I'm not aware of any Dells doing such a thing, if we encounter any > > then we can deal with that if and when that happens. > > Ok, go ahead. We can fix issues when appear later. These are queued to testing. Pali, I can only add a tag from you if you provide it in email. If you want your reviewed by on these, please include that in your replies. -- Darren Hart VMware Open Source Technology Center
