Re: [PATCH v9 4/4] platform/x86/dell-*: Call led_classdev_notify_brightness_hw_changed on kbd brightness change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 16 March 2017 11:55:35 Hans de Goede wrote:
> Changes in v9:
> -Only listen to type 0x0010 kbd-led events in dell-wmi.c, these only
> trigger on hotkey presses
> -Drop the new / previous brightness comparison from dell-laptop.c now
> that we only get events on hotkey presses it is no longer necessary
> ---

Hi! I'm really not sure if this change is correct there.

Now you are only listening for keypress "change kbd backlight", but some 
dell machines could change keyboard backlight also in other different 
situations, like attaching AC adapter. I guess (but I'm not sure) this 
probably does not send keypress event. 

-- 
Pali Rohár
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux