Re: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-02-09 at 12:17 +0530, Rajneesh Bhardwaj wrote:
> On Mon, Feb 06, 2017 at 05:09:51AM -0800, Shanth Murthy wrote:

> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>
 
> > +static int intel_pmc_s0ix_counter_read(u64 *data)
> > +{
> > +	return -EINVAL;
> > +}
> > +
> 
> How about making it static inline and return -ENOSYS instead of
> -EINVAL?

I'm not sure what's going on.
Your SoB is in this patch and now it feels like you are reviewing this
patch.

What should I do?

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux