> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, September 22, 2016 3:31 PM > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: dvhart@xxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx; > akpm@xxxxxxxxxxxxxxxxxxxx; kvalo@xxxxxxxxxxxxxx; mchehab@xxxxxxxxxx; > linux@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; platform-driver- > x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx > Subject: Re: [patch v1] drivers/platform/x86: introduce support for Mellanox > hotplug driver > > On Thu, Sep 22, 2016 at 01:14:27PM +0000, vadimp@xxxxxxxxxxxx wrote: > > From: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > > > Enable system support for the Mellanox Technologies hotplug platform > > driver, which provides support for the next Mellanox basic systems: > > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", > > "msb7800", "msn2740", "msn2100" and also various number of derivative > > systems from the above basic types. > > This driver handles hot-plug events for the power suppliers, power > > cables and fans for the above systems. > > > > The Kconfig currently controlling compilation of this code is: > > driver/platform/x86:config MLX_CPLD_PLATFORM > > tristate "Mellanox platform hotplug driver support" > > > > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > --- > > MAINTAINERS | 7 + > > drivers/platform/x86/Kconfig | 10 + > > drivers/platform/x86/Makefile | 1 + > > drivers/platform/x86/mlxcpld-hotplug.c | 543 > ++++++++++++++++++++++++++ > > include/linux/platform_data/mlxcpld-hotplug.h | 90 +++++ > > Why do you need a platform_data .h file for a stand-alone driver? > I have another module mlx-platform, which is reviewed now (I also got a number feedbacks from you on this matter). I want to activate mlxcpld-hotplug from this module. Like /* Platform hotplug default data */ static struct mlxcpld_hotplug_platform_data mlxplat_mlxcpld_hotplug_default_data = { /* Platform hotplug MSN21xx system family data*/ static struct mlxcpld_hotplug_platform_data mlxplat_mlxcpld_hotplug_msn21xx_data = { ... priv->pdev_hotplug = platform_device_register_resndata( &mlxplat_dev->dev, "mlxcpld-hotplug", -1, mlxplat_mlxcpld_hotplug_resources, ARRAY_SIZE(mlxplat_mlxcpld_hotplug_resources), mlxplat_hotplug, sizeof(*mlxplat_hotplug)); But I can't add this code to mlx-platfrom, until this one is not accepted. Thanks, Vadim. > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
