On Wed, May 18, 2016 at 07:37:00AM -0700, Guenter Roeck wrote: > On 05/17/2016 09:48 PM, Yong, Jonathan wrote: > >On 05/18/2016 12:03, Guenter Roeck wrote: > >>On 05/17/2016 08:26 PM, Yong, Jonathan wrote: > >>>The TCO I/O base is 40h rather than the usual 30h, and the > >>>re_reboot bit is at ACPIBASE+8. > >>> > >> > >>Does this mean that the code never worked, or in other words that it > >>was never tested, or are there now other chips which used the old > >>definitions which no longer work after this patch has been applied ? > > > >To my knowledge, it has never worked since 30h is claimed by ACPI GPE0_BLK. > > > Hmm.. Darren will have to take that one. I am not in a position to > determine if the new patch is correct or not, and/or if it causes some > other platform/architecture to fail. I'll Ack the other patch, and > would suggest for Darren to take it as well to keep the two patches together. I actually have the same exact question :-) The history of this driver is for Apollo Lake, so the question is if there exist v3 and v5 APL products, or if we only need to concern ourselves with v5 in the upstream driver. Especially given the "I don't know if this is the right way" in the cover letter, I will need an Acked-by at the very least from Qipeng. Jonathan, please remember to Cc ALL the maintainers and all the lists listed by get_maintainers when sending patches: $ scripts/get_maintainer.pl -f drivers/platform/x86/intel_pmc_ipc.c Zha Qipeng <qipeng.zha@xxxxxxxxx> (maintainer:INTEL PMC/P-Unit IPC DRIVER) Darren Hart <dvhart@xxxxxxxxxxxxx> (maintainer:X86 PLATFORM DRIVERS) platform-driver-x86@xxxxxxxxxxxxxxx (open list:INTEL PMC/P-Unit IPC DRIVER) linux-kernel@xxxxxxxxxxxxxxx (open list) In particular, ALL patches MUST cc LKML. > > Guenter > > >With this patch, watchdog ioctl is working properly with WDIOC_SETTIMEOUT, WDIOC_GETTIMEOUT and WDIOC_GETTIMELEFT as expected. > > > > -- > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
