Re: [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/17/2016 09:48 PM, Yong, Jonathan wrote:
On 05/18/2016 12:03, Guenter Roeck wrote:
On 05/17/2016 08:26 PM, Yong, Jonathan wrote:
The TCO I/O base is 40h rather than the usual 30h, and the
re_reboot bit is at ACPIBASE+8.


Does this mean that the code never worked, or in other words that it
was never tested, or are there now other chips which used the old
definitions which no longer work after this patch has been applied ?

To my knowledge, it has never worked since 30h is claimed by ACPI GPE0_BLK.

Hmm.. Darren will have to take that one. I am not in a position to
determine if the new patch is correct or not, and/or if it causes some
other platform/architecture to fail. I'll Ack the other patch, and
would suggest for Darren to take it as well to keep the two patches together.

Guenter

With this patch, watchdog ioctl is working properly with WDIOC_SETTIMEOUT, WDIOC_GETTIMEOUT and WDIOC_GETTIMELEFT as expected.


--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux