Pavel,
Either your clock is really off or it took you 3 weeks to get this
message out ;) Just letting you know.
> > +
> > +static enum led_brightness radio_led_get(struct led_classdev *cdev);
> > +static void radio_led_set(struct led_classdev *cdev,
> > + enum led_brightness brightness);
> > +
> > +static struct led_classdev radio_led = {
> > + .name = "fujitsu::radio_led",
> > + .brightness_get = radio_led_get,
> > + .brightness_set = radio_led_set
> > +};
>
> Is the naming consistent with other drivers?
I am not entirely clear what you are referring to. If it is the double
colon, that seems to be the convention used throughout the
platform-driver-x86 tree. If it is the LED's name ("radio_led"), I
failed to find a similarly purposed LED in the platform-driver-x86 tree
with a name I could reuse. I decided to use the _led suffix to
differentiate this LED from the "lamps" already implemented by
fujitsu-laptop.
> Should there be default trigger so that it works out of the box?
I have covered this issue in the lengthy comment attached to this patch:
> One last remark is that I think this LED would best be driven by an
> inverted airplane mode LED trigger (as proposed by João Paulo Rechi
> Vita). As the code for that trigger is not yet merged, I refrained from
> setting the default_trigger field in struct led_classdev radio_led.
> Perhaps it's a candidate for a follow-up patch in the future.
I haven't found a way to make this work the intended way out of the box,
not with the currently available set of LED triggers. That being said,
I would be happy if someone proved me wrong.
--
Best regards,
Michał Kępień
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
