Hi!
> Sadly, this implementation is unsuitable for use with "heavy" LED
> triggers, like phy0rx. Once blinking frequency achieves a certain
> level, the system hangs. I'm not sure how much of an issue this is as
> I'm pretty sure other LEDs registered by fujitsu-laptop would also cause
> a hang when assigned to a similar trigger as they are also controlled
> using ACPI.
Something to do with triggers working in interrupt context?
Cc led people?
> +
> +static enum led_brightness radio_led_get(struct led_classdev *cdev);
> +static void radio_led_set(struct led_classdev *cdev,
> + enum led_brightness brightness);
> +
> +static struct led_classdev radio_led = {
> + .name = "fujitsu::radio_led",
> + .brightness_get = radio_led_get,
> + .brightness_set = radio_led_set
> +};
Is the naming consistent with other drivers?
Should there be default trigger so that it works out of the box?
Best regards,
Pavel
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
