Looks good. Acked-by: Corentin Chary <corentin.chary@xxxxxxxxx> I'd like to get somebody from Asus help us guess these values instead of just hard-coding them.. Unfortunately I have no contact with them anymore. On Fri, Sep 4, 2015 at 12:54 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > On Wed, Sep 02, 2015 at 04:10:34PM -0600, Daniel Drake wrote: >> These laptops boot with wifi as hard-blocked, with no obvious way to >> enable it. Using a quirk to set wapf=4 solves the problem. >> >> Signed-off-by: Daniel Drake <drake@xxxxxxxxxxxx> > > Looks good. > > Corentin, any concerns? > >> --- >> drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c >> index abdaed3..131fee2 100644 >> --- a/drivers/platform/x86/asus-nb-wmi.c >> +++ b/drivers/platform/x86/asus-nb-wmi.c >> @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = { >> }, >> { >> .callback = dmi_matched, >> + .ident = "ASUSTeK COMPUTER INC. X456UA", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"), >> + }, >> + .driver_data = &quirk_asus_wapf4, >> + }, >> + { >> + .callback = dmi_matched, >> + .ident = "ASUSTeK COMPUTER INC. X456UF", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"), >> + }, >> + .driver_data = &quirk_asus_wapf4, >> + }, >> + { >> + .callback = dmi_matched, >> .ident = "ASUSTeK COMPUTER INC. X501U", >> .matches = { >> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> -- >> 2.1.4 >> >> > > -- > Darren Hart > Intel Open Source Technology Center -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html