On Sat, May 23, 2015 at 03:05:36AM +0200, Pali Rohár wrote: > On Saturday 23 May 2015 00:53:16 Dmitry Torokhov wrote: > > On Thu, May 21, 2015 at 7:06 PM, Valdis Kletnieks > > > > <Valdis.Kletnieks@xxxxxx> wrote: > > > So after I made both config variables =y, the resulting kernel > > > built, but died a glorious death at boot. > > > > I guess if both are built-in then, according to link order, > > dell-laptop starts first, before dell-rbtn, and dies in > > dell_rbtn_notifier_register() in call to > > driver_for_each_device(&rbtn_driver.drv, ...) because rbtn_driver has > > not been registered yet and thus half-initlalized. > > > > Thanks. > > pr_debug() messages could be useful... but no idea if we can get them. > > Is there any way to fix that dependency race condition? Could > driver_attach() function call help? I believe you can avoid this by moving dell-rbtn earlier in the Makefile than dell-laptop - but this is fragile and a hack to resolve a dependency problem. I suppose this is why thinkpad-acpi.c is huge, and why having separate drivers talk to eachother is discouraged. dell-laptop seems to be the base, while dell-rbtn is the more specific of the two - which makes dell-laptop calling a dell-rbtn function which requires dell-rbtn to have been initialized prior a poor approach. Greg, Matthew, I'm tempted to recommend this 434 line driver be rolled into dell-laptop.c. Any strong opinions? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
