Hi Darren Hart I double checked no compile fail on my side. And could you check if enable config option " CONFIG_INTEL_PMC_IPC", Seems the error is due to this, please check intel_pmc_ipc.h for detail Thanks And by using checkpatch.pl, found there is really warning as below I will sent update one Great thanks:) qzha $ scripts/checkpatch.pl 0001-platform-x86-add-Intel-Broxton-PMC-IPC-driver.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 WARNING: 'resoures' may be misspelled - perhaps 'resources'? #207: FILE: drivers/platform/x86/intel_pmc_ipc.c:69: + * but export multi resoures on one ACPI device(IPC) for total: 0 errors, 2 warnings, 863 lines checked 0001-platform-x86-add-Intel-Broxton-PMC-IPC-driver.patch has style problems, please review. Best wishes Qipeng -----Original Message----- From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] Sent: Wednesday, May 20, 2015 5:29 PM To: Zha, Qipeng Cc: platform-driver-x86@xxxxxxxxxxxxxxx; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH v2] platform:x86: add Intel Broxton PMC IPC driver On Mon, May 18, 2015 at 10:08:50PM +0800, qipeng.zha wrote: > From: "qipeng.zha" <qipeng.zha@xxxxxxxxx> > > This driver provides support for PMC control on Broxton platforms, PMC > is ARC processor which defined some IPC commands for communication > with other entities running in IA > > Signed-off-by: qipeng.zha <qipeng.zha@xxxxxxxxx> Please run through checkpatch.pl and correct errors. Compilation fails: CC [M] drivers/platform/x86/intel_pmc_ipc.o drivers/platform/x86/intel_pmc_ipc.c:214:5: error: redefinition of ‘intel_pmc_ipc_simple_command’ int intel_pmc_ipc_simple_command(int cmd, int sub) ^ In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0: ./arch/x86/include/asm/intel_pmc_ipc.h:63:19: note: previous definition of ‘intel_pmc_ipc_simple_command’ was here static inline int intel_pmc_ipc_simple_command(int cmd, int sub) ^ drivers/platform/x86/intel_pmc_ipc.c:242:5: error: redefinition of ‘intel_pmc_ipc_raw_cmd’ int intel_pmc_ipc_raw_cmd(u32 cmd, u32 sub, u8 *in, u32 inlen, u32 *out, ^ In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0: ./arch/x86/include/asm/intel_pmc_ipc.h:68:19: note: previous definition of ‘intel_pmc_ipc_raw_cmd’ was here static inline int intel_pmc_ipc_raw_cmd(u32 cmd, u32 sub, u8 *in, u32 inlen, ^ drivers/platform/x86/intel_pmc_ipc.c:286:5: error: redefinition of ‘intel_pmc_ipc_command’ int intel_pmc_ipc_command(u32 cmd, u32 sub, u8 *in, u32 inlen, ^ In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0: ./arch/x86/include/asm/intel_pmc_ipc.h:74:19: note: previous definition of ‘intel_pmc_ipc_command’ was here static inline int intel_pmc_ipc_command(u32 cmd, u32 sub, u8 *in, u32 inlen, ^ scripts/Makefile.build:264: recipe for target 'drivers/platform/x86/intel_pmc_ipc.o' failed make[1]: *** [drivers/platform/x86/intel_pmc_ipc.o] Error 1 Makefile:1552: recipe for target 'drivers/platform/x86/intel_pmc_ipc.ko' failed make: *** [drivers/platform/x86/intel_pmc_ipc.ko] Error 2 -- Darren Hart Intel Open Source Technology Center ��.n��������+%������w��{.n������_���v��z����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
