On Mon, May 18, 2015 at 10:08:50PM +0800, qipeng.zha wrote: > From: "qipeng.zha" <qipeng.zha@xxxxxxxxx> > > This driver provides support for PMC control on Broxton platforms, > PMC is ARC processor which defined some IPC commands for communication > with other entities running in IA > > Signed-off-by: qipeng.zha <qipeng.zha@xxxxxxxxx> Please run through checkpatch.pl and correct errors. Compilation fails: CC [M] drivers/platform/x86/intel_pmc_ipc.o drivers/platform/x86/intel_pmc_ipc.c:214:5: error: redefinition of ‘intel_pmc_ipc_simple_command’ int intel_pmc_ipc_simple_command(int cmd, int sub) ^ In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0: ./arch/x86/include/asm/intel_pmc_ipc.h:63:19: note: previous definition of ‘intel_pmc_ipc_simple_command’ was here static inline int intel_pmc_ipc_simple_command(int cmd, int sub) ^ drivers/platform/x86/intel_pmc_ipc.c:242:5: error: redefinition of ‘intel_pmc_ipc_raw_cmd’ int intel_pmc_ipc_raw_cmd(u32 cmd, u32 sub, u8 *in, u32 inlen, u32 *out, ^ In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0: ./arch/x86/include/asm/intel_pmc_ipc.h:68:19: note: previous definition of ‘intel_pmc_ipc_raw_cmd’ was here static inline int intel_pmc_ipc_raw_cmd(u32 cmd, u32 sub, u8 *in, u32 inlen, ^ drivers/platform/x86/intel_pmc_ipc.c:286:5: error: redefinition of ‘intel_pmc_ipc_command’ int intel_pmc_ipc_command(u32 cmd, u32 sub, u8 *in, u32 inlen, ^ In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0: ./arch/x86/include/asm/intel_pmc_ipc.h:74:19: note: previous definition of ‘intel_pmc_ipc_command’ was here static inline int intel_pmc_ipc_command(u32 cmd, u32 sub, u8 *in, u32 inlen, ^ scripts/Makefile.build:264: recipe for target 'drivers/platform/x86/intel_pmc_ipc.o' failed make[1]: *** [drivers/platform/x86/intel_pmc_ipc.o] Error 1 Makefile:1552: recipe for target 'drivers/platform/x86/intel_pmc_ipc.ko' failed make: *** [drivers/platform/x86/intel_pmc_ipc.ko] Error 2 -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html