Looks fine to me.
Acked-by: Jonathan Woithe <jwoithe@xxxxxxxxxx>
On Wed, Jul 16, 2014 at 07:43:11PM +0200, Mathias Krause wrote:
> The DMI table is only ever used during initialization. Mark it as
> __initconst so its memory can be released afterwards -- roughly 1.5 kB.
> In turn, the callback functions can be marked with __init, too.
>
> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> Cc: Jonathan Woithe <jwoithe@xxxxxxxxxx>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index e6f336270c..e9345f12ce 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -564,7 +564,7 @@ static struct platform_driver fujitsupf_driver = {
> }
> };
>
> -static void dmi_check_cb_common(const struct dmi_system_id *id)
> +static void __init dmi_check_cb_common(const struct dmi_system_id *id)
> {
> pr_info("Identified laptop model '%s'\n", id->ident);
> if (use_alt_lcd_levels == -1) {
> @@ -578,7 +578,7 @@ static void dmi_check_cb_common(const struct dmi_system_id *id)
> }
> }
>
> -static int dmi_check_cb_s6410(const struct dmi_system_id *id)
> +static int __init dmi_check_cb_s6410(const struct dmi_system_id *id)
> {
> dmi_check_cb_common(id);
> fujitsu->keycode1 = KEY_SCREENLOCK; /* "Lock" */
> @@ -586,7 +586,7 @@ static int dmi_check_cb_s6410(const struct dmi_system_id *id)
> return 1;
> }
>
> -static int dmi_check_cb_s6420(const struct dmi_system_id *id)
> +static int __init dmi_check_cb_s6420(const struct dmi_system_id *id)
> {
> dmi_check_cb_common(id);
> fujitsu->keycode1 = KEY_SCREENLOCK; /* "Lock" */
> @@ -594,7 +594,7 @@ static int dmi_check_cb_s6420(const struct dmi_system_id *id)
> return 1;
> }
>
> -static int dmi_check_cb_p8010(const struct dmi_system_id *id)
> +static int __init dmi_check_cb_p8010(const struct dmi_system_id *id)
> {
> dmi_check_cb_common(id);
> fujitsu->keycode1 = KEY_HELP; /* "Support" */
> @@ -603,7 +603,7 @@ static int dmi_check_cb_p8010(const struct dmi_system_id *id)
> return 1;
> }
>
> -static struct dmi_system_id fujitsu_dmi_table[] = {
> +static const struct dmi_system_id fujitsu_dmi_table[] __initconst = {
> {
> .ident = "Fujitsu Siemens S6410",
> .matches = {
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
