On Wed, 16 Jul 2014, Mathias Krause wrote:
> Mark volume_alsa_control_vol and volume_alsa_control_mute as __initdata,
> as snd_ctl_new1() will copy the relevant parts, so there is no need to
> keep the master copies around after initialization.
>
> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> Cc: Henrique de Moraes Holschuh <ibm-acpi@xxxxxxxxxx>
Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index d82f196e3c..0f48cade28 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6860,7 +6860,7 @@ static int volume_alsa_mute_put(struct snd_kcontrol *kcontrol,
> return volume_alsa_set_mute(!ucontrol->value.integer.value[0]);
> }
>
> -static struct snd_kcontrol_new volume_alsa_control_vol = {
> +static struct snd_kcontrol_new volume_alsa_control_vol __initdata = {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "Console Playback Volume",
> .index = 0,
> @@ -6869,7 +6869,7 @@ static struct snd_kcontrol_new volume_alsa_control_vol = {
> .get = volume_alsa_vol_get,
> };
>
> -static struct snd_kcontrol_new volume_alsa_control_mute = {
> +static struct snd_kcontrol_new volume_alsa_control_mute __initdata = {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "Console Playback Switch",
> .index = 0,
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
