Hi,
I saw a number of discussion on new thinkpad led and caused me to
re-think about my previous patch.
The previous patches add interfaces to control hardware mute via BIOS
functions; however there are nobody to control it and the problem of
out-of-sync between hardware mute and software mute will still exist.
Will it be a better idea to disable hardware mute? The hardware mute
will still send a scancode to mute the volue when thinkpad-acpi is
loaded, though the led will still not work. More specifically, a patch
that only calls with hoteky_set_mute_support(1) that works as below:
+static int hotkey_set_mute_support(int support)
+{
+ int output;
+
+ if (!acpi_evalf(hkey_handle, &output, "SHDA", "dd", support))
+ return -EIO;
+
+ if (output & TPACPI_AML_MUTE_ERROR_STATE_MASK) {
+ pr_warning("setting mute support failed.\n");
+ return -EIO;
+ }
+ pr_info("%s mute led support.\n", support ? "disable" : "enable");
+
+ return 0;
+}
This can solve the problems that unmute from desktop will not unmute the
hardware mute until someone including myself works out a more
comprehensive solution.
Best Regards,
Alex Hung
On 04/11/2012 07:42 PM, Henrique de Moraes Holschuh wrote:
On Wed, 11 Apr 2012, Alex Hung wrote:
I am modifying thinkpad_acpi so it can support the mute led, and I
am looking for suggestions and feedbacks.
For newer BIOS, it includes three aml methods that can be used to
get, set and enable the mute led.
Aha! THANK YOU.
I will look at the patches this week. Please send me (directly) a full
dmidecode and ACPI table dump.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
